only send messages to valid emails #6551
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c7b4b80 to
462df6f
Compare
akatsoulas
requested changes
Mar 11, 2025
0e0abcb to
7e0805e
Compare
7e0805e to
34b7b2a
Compare
akatsoulas
approved these changes
Mar 12, 2025
| @@ -132,3 +133,26 @@ def test_styles_inlining(self): | |||
| for m in msg: | |||
| tag = '<a href="https://%s/test" style="color:#000">Hyperlink</a>' | |||
| self.assertIn(tag % Site.objects.get_current().domain, str(m.message())) | |||
|
|
|||
|
|
|||
| class SendMessagesTests(TestCase): | |||
There was a problem hiding this comment.
It would be nice to add a test with invalid emails too
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mozilla/sumo#2243